Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore directives feature #343

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Ignore directives feature #343

merged 3 commits into from
Jun 28, 2023

Conversation

u5surf
Copy link
Contributor

@u5surf u5surf commented Jun 11, 2023 •
edited by dhurley
Loading

Proposed changes

Fixes: #229

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Jun 11, 2023 •
edited
Loading

✅ Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 3f7e887
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/648725723d73340008b2da77

@github-actions github-actions bot added chore Pull requests for routine tasks enhancement New feature or request labels Jun 11, 2023
@u5surf u5surf marked this pull request as ready for review June 12, 2023 14:03
@dhurley dhurley changed the title Ignore directives features (#229) Ignore directives feature (#229) Jun 28, 2023
@dhurley dhurley removed dependencies chore Pull requests for routine tasks labels Jun 28, 2023
@dhurley dhurley changed the title Ignore directives feature (#229) Ignore directives feature Jun 28, 2023
@dhurley dhurley merged commit a0b2d84 into nginx:main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aphralG aphralG aphralG approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@dhurley dhurley dhurley approved these changes

@oliveromahony oliveromahony oliveromahony approved these changes

@craigell craigell Awaiting requested review from craigell

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to ignore sensitive info while parsing nginx configs
5 participants
@u5surf @oliveromahony @dhurley @Dean-Coakley @aphralG